AaronBallman wrote: > as someone dealing with c/c++ I don't really get why 0 column number is > invalid, but that is already clearer, thanks
Lines and columns are one-based, but now I wonder if this change is correct because we do accept zero-based line numbers as a GNU extension. So it *is* possible to get a zero-based value, and we currently mess up with it: https://godbolt.org/z/8KMY3j7T9 Note how the second warning says `<source>:4294967295:8:` @shafik does that code now cause an assertion? https://github.com/llvm/llvm-project/pull/153527 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
