[clang] [Clang] improve -Wstring-concatenation to warn on every missing comma in initializer lists (PR #154018)

[Mariya Podchishchaeva via cfe-commits]

================
@@ -14708,7 +14708,16 @@ void Sema::CheckCompleteVariableDeclaration(VarDecl 
*var) {
       isa<InitListExpr>(var->getInit())) {
     const auto *ILE = cast<InitListExpr>(var->getInit());
     unsigned NumInits = ILE->getNumInits();
-    if (NumInits > 2)
+    if (NumInits > 2) {
+      auto concatenatedPartsAt = [&](unsigned Index) -> unsigned {
+        const Expr *E = ILE->getInit(Index);
+        if (E) {
+          if (const auto *S = dyn_cast<StringLiteral>(E->IgnoreImpCasts()))
+            return S->getNumConcatenated();
+        }
----------------
Fznamznon wrote:

```suggestion
        if (const Expr *E = ILE->getInit(Index))
          if (const auto *S = dyn_cast<StringLiteral>(E->IgnoreImpCasts()))
            return S->getNumConcatenated();
```

https://github.com/llvm/llvm-project/pull/154018
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits