krasimir marked an inline comment as done.
krasimir added inline comments.
================
Comment at: clangd/ClangdUnit.cpp:153
Item.kind = getKind(Result.CursorKind);
+ Item.insertText = CCS->getTypedText();
if (CCS->getBriefComment())
----------------
ilya-biryukov wrote:
> Should we also update sortText and filterText, which use label by default,
> just like insertText?
Good point!
================
Comment at: test/clangd/completion.test:32
# CHECK: {"jsonrpc":"2.0","id":1,"result":[
-# CHECK-DAG: {"label":"a","kind":5}
-# CHECK-DAG: {"label":"bb","kind":5}
-# CHECK-DAG: {"label":"ccc","kind":5}
+# CHECK-DAG: {"label":"a","kind":5,"detail":"int","insertText":"a"}
# CHECK: ]}
----------------
ilya-biryukov wrote:
> Should we repeat repeat the checks added above here too?
This test case is about understanding 'file:/main.cpp', so I don't think
repeating everything would be beneficial.
https://reviews.llvm.org/D34033
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
