erichkeane wrote: > You need to realize that submitted this code for review in May. It's like > that I forgot some of the details of why I wrote something. But what I wrote > was intentionally put there for a reason. > > There's a new commit. PTAL.
Honestly, this is a case where I was heavily unmotivated to review your code due to past behavior, and didn't until asked explicitly by Aaron. It waited due to your inability to respect reviewers in the past. > And if you're flagging this for "changes required", please list those changes. Due to me "lacking a fundamental understanding of the code" I need to spend extensive amounts of time familiarizing myself with "the code" before I can release this review. https://github.com/llvm/llvm-project/pull/141846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
