https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/151969
Summary:
These arguments are synthetically generated and should always be
considered used. This was emitting a warning on the new driver.
>From 46c3f620fb837bc884a7129b3d651b674a164ff9 Mon Sep 17 00:00:00 2001
From: Joseph Huber <hube...@outlook.com>
Date: Mon, 4 Aug 2025 08:55:29 -0500
Subject: [PATCH] [Clang] Fix warning on synthetic offload arch argument in
host only mode
Summary:
These arguments are synthetically generated and should always be
considered used. This was emitting a warning on the new driver.
---
clang/lib/Driver/Driver.cpp | 1 +
clang/test/Driver/hip-options.hip | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp
index 586f287843f3e..8c0bba938a09b 100644
--- a/clang/lib/Driver/Driver.cpp
+++ b/clang/lib/Driver/Driver.cpp
@@ -1012,6 +1012,7 @@ inferOffloadToolchains(Compilation &C,
Action::OffloadKind Kind) {
Arg *A = new Arg(Opt, C.getArgs().getArgString(Index), Index,
C.getArgs().MakeArgString(Triple.split("-").first),
C.getArgs().MakeArgString("--offload-arch=" + Arch));
+ A->claim();
C.getArgs().append(A);
C.getArgs().AddSynthesizedArg(A);
Triples.insert(Triple);
diff --git a/clang/test/Driver/hip-options.hip
b/clang/test/Driver/hip-options.hip
index ba23bc2d59b56..6206020d76db6 100644
--- a/clang/test/Driver/hip-options.hip
+++ b/clang/test/Driver/hip-options.hip
@@ -241,7 +241,7 @@
// Check --offload-compress --offload-jobs=N does not cause warning.
// RUN: %clang -### -Werror --target=x86_64-unknown-linux-gnu -nogpuinc
-nogpulib \
// RUN: --offload-arch=gfx1100 --offload-compress --offload-host-only -M %s \
-// RUN: --offload-jobs=4
+// RUN: --offload-jobs=4 --offload-new-driver
// Check --offload-jobs=N option.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
