https://github.com/5chmidti commented:
Awesome to see this continuing. The changes also look quite clean and extendable to, e.g., modules, like you mentioned. The performance improvement is still incredible to see. Especially when considering library layering in user-code from external or internal libraries, giving this a potentially much stronger impact on analysis time. I'm not sure if we could recover the last ~2.5s compared to the previous change without breaking something. It's probably an LGTM from me, but I will think about the change for a bit and try it out a bit in a few days (e.g., w.r.t. macros). https://github.com/llvm/llvm-project/pull/151035 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
