https://github.com/vbvictor commented:

Thank you for working on this.
This change is worth ReleaseNotes IMO, you could add them, we had [release 
notes 
](https://github.com/llvm/llvm-project/blob/release/21.x/clang-tools-extra/docs/ReleaseNotes.rst#improvements-to-clang-tidy)for
 change in `check_clang_tidy`.

Nit: try to start PR header with "Add/Fix/Update/Make" as majority commits in 
LLVM (e.g. `Add -std argument in check_clang_tidy.py for C files`). It takes 
less time for the reviewer to understand what you did because it follows 
established format. In general it's good to follow [conventional 
commits](https://www.conventionalcommits.org/en/v1.0.0/) (but LLVM use `add` 
instead of `feat`).

https://github.com/llvm/llvm-project/pull/150791
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to