================
@@ -181,14 +181,14 @@ template <bool IsConst> class
DynamicRecursiveASTVisitorBase {
///
/// \returns false if the visitation was terminated early, true
/// otherwise (including when the argument is a Null type).
- virtual bool TraverseType(QualType T);
+ virtual bool TraverseType(QualType T, bool TraverseQualifier = true);
----------------
Sirraide wrote:
> Can we add data member/member function
> `[Dynamic]RecursiveASTVisitor::shouldVisitQualifier` instead of adding
> function parameter?
I was going to comment that too at first when I looked at this pr, but I don’t
think that approach makes as much sense in this particular case because we
explictly pass `false`/`true` in a few places for this parameter in the RAV
implementation, whereas the `shouldXYZ()` functions are something whose value
is usually (or always, I think?) specified by the derived class and not by RAV
itself.
So yeah, I agree it makes more sense to keep this as a parameter.
https://github.com/llvm/llvm-project/pull/147835
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
