vbvictor wrote: > Are they really need to "std::move" in the patch? I think `MixData` is > meaningless since it is still need to copy all field.
Do you mean with `CheckTriviallyCopyableMove` set to `true`? Technically, there would probably be no performance benefit. However, from author's point of view, he intended not to use that data anymore so he used `std::move` to "semantically" flag it. I'm more in favor of preserving "semantics" so put `CheckTriviallyCopyableMove` to false. https://github.com/llvm/llvm-project/pull/148549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
