llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> getArgAsExpr already returns Expr *. --- Full diff: https://github.com/llvm/llvm-project/pull/148871.diff 4 Files Affected: - (modified) clang/lib/Sema/SemaDeclAttr.cpp (+1-1) - (modified) clang/lib/Sema/SemaM68k.cpp (+1-1) - (modified) clang/lib/Sema/SemaMSP430.cpp (+1-1) - (modified) clang/lib/Sema/SemaType.cpp (+1-1) ``````````diff diff --git a/clang/lib/Sema/SemaDeclAttr.cpp b/clang/lib/Sema/SemaDeclAttr.cpp index 5f481ed1f7139..78f4804202ddc 100644 --- a/clang/lib/Sema/SemaDeclAttr.cpp +++ b/clang/lib/Sema/SemaDeclAttr.cpp @@ -6247,7 +6247,7 @@ static void handleInterruptAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleLayoutVersion(Sema &S, Decl *D, const ParsedAttr &AL) { uint32_t Version; - Expr *VersionExpr = static_cast<Expr *>(AL.getArgAsExpr(0)); + Expr *VersionExpr = AL.getArgAsExpr(0); if (!S.checkUInt32Argument(AL, AL.getArgAsExpr(0), Version)) return; diff --git a/clang/lib/Sema/SemaM68k.cpp b/clang/lib/Sema/SemaM68k.cpp index f091827092f83..7a4fcbdb99a99 100644 --- a/clang/lib/Sema/SemaM68k.cpp +++ b/clang/lib/Sema/SemaM68k.cpp @@ -32,7 +32,7 @@ void SemaM68k::handleInterruptAttr(Decl *D, const ParsedAttr &AL) { // FIXME: Check for decl - it should be void ()(void). - Expr *NumParamsExpr = static_cast<Expr *>(AL.getArgAsExpr(0)); + Expr *NumParamsExpr = AL.getArgAsExpr(0); auto MaybeNumParams = NumParamsExpr->getIntegerConstantExpr(getASTContext()); if (!MaybeNumParams) { Diag(AL.getLoc(), diag::err_attribute_argument_type) diff --git a/clang/lib/Sema/SemaMSP430.cpp b/clang/lib/Sema/SemaMSP430.cpp index 5bf931e388f03..3c611f7a27e23 100644 --- a/clang/lib/Sema/SemaMSP430.cpp +++ b/clang/lib/Sema/SemaMSP430.cpp @@ -53,7 +53,7 @@ void SemaMSP430::handleInterruptAttr(Decl *D, const ParsedAttr &AL) { return; } - Expr *NumParamsExpr = static_cast<Expr *>(AL.getArgAsExpr(0)); + Expr *NumParamsExpr = AL.getArgAsExpr(0); std::optional<llvm::APSInt> NumParams = llvm::APSInt(32); if (!(NumParams = NumParamsExpr->getIntegerConstantExpr(getASTContext()))) { Diag(AL.getLoc(), diag::err_attribute_argument_type) diff --git a/clang/lib/Sema/SemaType.cpp b/clang/lib/Sema/SemaType.cpp index bb114aff2366b..7dbd4bb0ed125 100644 --- a/clang/lib/Sema/SemaType.cpp +++ b/clang/lib/Sema/SemaType.cpp @@ -6533,7 +6533,7 @@ static void HandleAddressSpaceTypeAttribute(QualType &Type, return; } - Expr *ASArgExpr = static_cast<Expr *>(Attr.getArgAsExpr(0)); + Expr *ASArgExpr = Attr.getArgAsExpr(0); LangAS ASIdx; if (!BuildAddressSpaceIndex(S, ASIdx, ASArgExpr, Attr.getLoc())) { Attr.setInvalid(); `````````` </details> https://github.com/llvm/llvm-project/pull/148871 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
