tyan0 wrote:

> It looks like some linker options might still be missing or need adjustments:
> 
> * `--enable-auto-import`, `--disable-high-entropy-va`, and 
> `--dll-search-prefix=cyg` are generally required on Cygwin.
> * `-pie` has no effect when targeting PE/COFF and can be ignored.
> 
> Also, a few options should be handled in both `class Cygwin` and in the 
> linker job construction:
> 
> * `-mwindows` should be translated into `--subsystem=windows`.
> * `-shared` and `-mdll` are subtly different in what they instruct GCC to 
> link with.

I have been convinced by your points regarding `-dll-search-prefix=cyg`, 
`-pie`, `-mwindows`, `-shared`, and `-mdll`. These have been implemented to the 
PR.

However, as for `--enable-auto-import` and `--disable-high-entropy-va`, gcc/g++ 
do not add these flags by default. I doubt these are really necessary. Why do 
you think these are needed?


https://github.com/llvm/llvm-project/pull/147960
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to