AaronBallman wrote: > Thanks for the suggestions Aaron, applied them both and refreshed the branch > (it doesn't stay fresh for long it seems 😄) > > When it comes to `[[gnu::`, options seems to be > > * Leave as-is, no change: no error, no warning but string is dropped > > * Align with GCC and error on passing a string: we would break existing > code as they pass just fine now with a string in, it's just ignored. > > * Keep and display the string (with or without additional warning): > Decent user experience, and does not introduce breakage > > > Let me know where you stand
I think we're good with the current behavior in your patch. I'll land the changes when CI comes back green. We can decide later if we want to do something about the `gnu` spelling. https://github.com/llvm/llvm-project/pull/148090 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
