================
@@ -0,0 +1,43 @@
+// REQUIRES: lld
+
+/// Check DTLTO options are forwarded to the linker.
+
+// RUN: echo "--target=x86_64-linux-gnu \
+// RUN:   -Xthinlto-distributor=distarg1 \
+// RUN:   -Xthinlto-distributor=distarg2,distarg3 \
+// RUN:   -fuse-ld=lld" > %t.rsp
----------------
bd1976bris wrote:

> I'm not sure I follow you here, so maybe I'm missing some context? First, I 
> don't see any response file other than the one you're creating here.

Hmm... I think your comment might be attached to the commit you made the 
comment against rather than the branch as it is now, try: 
https://github.com/llvm/llvm-project/pull/147265/files and then click on 
`clang/test/Driver/DTLTO/dtlto.c` in the sidebar.

> Or are you relying on substitution happening in the `echo` command? If so, 
> that isn't a practice I've seen in many tests, and I'm not sure we want to 
> encourage more use of that pattern.

It's quite a nice way to make tests more readable when there are various test 
cases where the tools in the test all accept some common set of options, no? A 
`lit` macro might be another way of achieving this, but I'm not sure that many 
people are familiar with the syntax.

https://github.com/llvm/llvm-project/pull/147265
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to