AaronBallman wrote:

> > I suppose another option is to use a regex in the test to accept either 
> > form of canonicalization with a comment that lit tests are sometimes run 
> > from network mounts and that's why the test is the way it is.
> 
> I mean, at that point we can just delete the test entirely though because 
> testing that ‘either it canonicalises the path or it doesn’t’ feels a bit 
> tautological...

Yeah, but it does test we don't generate something else entirely invented. :-D 
But yeah, not a super useful test, I suppose.

https://github.com/llvm/llvm-project/pull/143520
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to