llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang

@llvm/pr-subscribers-clang-driver

Author: Daniel Paoliello (dpaoliello)

<details>
<summary>Changes</summary>

Some targets, such as `aarch64-pc-windows-msvc`, always require that Frame 
Pointer be reserved even when `-fomit-frame-pointer` is provided, thus it is 
always valid to use `-pg` on those targets.

This test didn't take these targets into account; thus it was failing on Arm64 
Windows host machines.

The fix is to explicitly set a target that doesn't require Frame Pointers 
reservation.

---
Full diff: https://github.com/llvm/llvm-project/pull/148000.diff


1 Files Affected:

- (modified) clang/test/Driver/frame-pointer-elim.c (+2-2) 


``````````diff
diff --git a/clang/test/Driver/frame-pointer-elim.c 
b/clang/test/Driver/frame-pointer-elim.c
index 0dd7eb0c738db..f00940bd7613d 100644
--- a/clang/test/Driver/frame-pointer-elim.c
+++ b/clang/test/Driver/frame-pointer-elim.c
@@ -44,8 +44,8 @@
 // RUN:   FileCheck --check-prefix=KEEP-NONE %s
 
 // -pg -fomit-frame-pointer => error.
-// RUN: not %clang -### -S -fomit-frame-pointer -pg %s 2>&1 | FileCheck 
-check-prefix=CHECK-NO-MIX-OMIT-FP-PG %s
-// RUN: %clang -### -S -fomit-frame-pointer -fno-omit-frame-pointer -pg %s 
2>&1 | FileCheck -check-prefix=CHECK-MIX-NO-OMIT-FP-PG %s
+// RUN: not %clang -### --target=i386-linux -S -fomit-frame-pointer -pg %s 
2>&1 | FileCheck -check-prefix=CHECK-NO-MIX-OMIT-FP-PG %s
+// RUN: %clang -### --target=i386-linux -S -fomit-frame-pointer 
-fno-omit-frame-pointer -pg %s 2>&1 | FileCheck 
-check-prefix=CHECK-MIX-NO-OMIT-FP-PG %s
 // CHECK-NO-MIX-OMIT-FP-PG: '-fomit-frame-pointer' not allowed with '-pg'
 // CHECK-MIX-NO-OMIT-FP-PG-NOT: '-fomit-frame-pointer' not allowed with '-pg'
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/148000
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to