https://github.com/PiotrZSL requested changes to this pull request.
I'm not sure if this check changes anything related to performance. Most of this stuff is optimized, local variables with builtin types will be optimized-out anyway and types that actually could harm performance cannot be constexpr. Additionally for such types you move them from stack to rdata/bss section, and that can introduce cache-miss. For me check: - Should ignore all builtin types (int, char, pointers, ...) - Should have an option to ignore classes/structures bellow specific size But still, I think that this check doesn't make sense, unless you can show example where it actually change something. https://github.com/llvm/llvm-project/pull/147809 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
