================ @@ -235,6 +288,30 @@ bool SemaSPIRV::CheckSPIRVBuiltinFunctionCall(const TargetInfo &TI, TheCall->setType(RetTy); break; } + case SPIRV::BI__builtin_spirv_refract: { + if (SemaRef.checkArgCount(TheCall, 3)) + return true; + + llvm::function_ref<bool(Sema *, SourceLocation, int, QualType)> + ChecksArr[] = {CheckFloatOrHalfRepresentation, ---------------- farzonl wrote:
I’ll review this tomorrow, but supporting scalars here seems wrong. I’m almost 100% sure that spirv only supports vectors and that our semantics should match that. https://github.com/llvm/llvm-project/pull/147342 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits