vbvictor wrote: > > Please remove unnecessary comments that tell the same as code itself, > > speaking mostly about comments in `registerMatchers`. They mostly don't > > give any more information that matchers themselves. > > To be honest, this is because I coded 98% of this with AI (except for the > `.rst` documentation text which I mostly wrote myself). I am still getting > used to stripping out useless comments and also how `llvm`/compilers in > general work.
In my experience, AI generally simplify things and try to compare types as "raw string" and match patters like text, not AST. To counter it, I'd always guide it to look at other checks and AST-dump to understand context. https://github.com/llvm/llvm-project/pull/146970 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
