Author: Zahira Ammarguellat Date: 2025-07-07T06:57:51-04:00 New Revision: f34de0a14fa9fac737f042dea3df986dd161adbe
URL: https://github.com/llvm/llvm-project/commit/f34de0a14fa9fac737f042dea3df986dd161adbe DIFF: https://github.com/llvm/llvm-project/commit/f34de0a14fa9fac737f042dea3df986dd161adbe.diff LOG: [clang-tidy] [NFC] Potential dereference of nullptr. (#143145) The static analyzer we use internally complains about potential dereference of `nullptr` for `Found`. I think both `Found` and `Member` can't be null here (please confirm). I have added assertions. Added: Modified: clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp index 4aba5831e6772..23de8d971898e 100644 --- a/clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/MisleadingSetterOfReferenceCheck.cpp @@ -50,6 +50,8 @@ void MisleadingSetterOfReferenceCheck::check( const MatchFinder::MatchResult &Result) { const auto *Found = Result.Nodes.getNodeAs<CXXMethodDecl>("bad-set-function"); const auto *Member = Result.Nodes.getNodeAs<FieldDecl>("member"); + assert(Found != nullptr); + assert(Member != nullptr); diag(Found->getBeginLoc(), "function '%0' can be mistakenly used in order to change the " _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
