================ @@ -832,13 +835,11 @@ FileID SourceManager::getFileIDLocal(SourceLocation::UIntTy SLocOffset) const { unsigned LessIndex = 0; // upper bound of the search range. unsigned GreaterIndex = LocalSLocEntryTable.size(); - if (LastFileIDLookup.ID >= 0) { - // Use the LastFileIDLookup to prune the search space. - if (LocalSLocEntryTable[LastFileIDLookup.ID].getOffset() < SLocOffset) - LessIndex = LastFileIDLookup.ID; - else - GreaterIndex = LastFileIDLookup.ID; - } + // Use the LastFileIDLookup to prune the search space. + if (LastLookupStartOffset < SLocOffset) + LessIndex = LastFileIDLookup.ID; ---------------- erichkeane wrote:
Oh! Does this mean that the old test here (`LastFileIDLookup.ID >= 0`) was a dead branch? Or actually, the alternative? Always executed? Thats why i asked... https://github.com/llvm/llvm-project/pull/146782 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits