================ @@ -1543,9 +1543,11 @@ def AtomicUpdateOp : OpenMP_Op<"atomic.update", traits = [ operations. }] # clausesDescription; - let arguments = !con((ins Arg<OpenMP_PointerLikeType, - "Address of variable to be updated", - [MemRead, MemWrite]>:$x), clausesArgs); + let arguments = !con( + (ins Arg<OpenMP_PointerLikeType, + "Address of variable to be updated", [MemRead, MemWrite]>:$x, + AtomicControlAttr:$atomic_control), ---------------- skatrak wrote:
Why have you made this attribute required? There's a clear default for it (all flags set to false) and, even in the unit tests you had to update because of this choice, the attribute is specified but empty. https://github.com/llvm/llvm-project/pull/143441 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits