https://github.com/erichkeane commented:

I did a light pass of the 1st 1/4 of this or so.  The smuggling back and forth 
to raw-encoding seems strange?  WHy are we doing that here?

Otherwise just minor questions/requested analysis.

FWIW, I'm reasonably comfortable with just pulling this band-aid, but the Area 
Team probably needs to make the determination (and we need to spend more time 
on this review).

https://github.com/llvm/llvm-project/pull/146314
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to