================

----------------
rj-jesus wrote:

I'm just not sure what test coverage the Neoverse V2 file brings.

I assume the goal of having both files (Neoverse V2 and Grace) is to ensure 
that we don't enable the crypto features added in this patch if `/proc/cpuinfo` 
doesn't list them. But there are already other mock cpuinfo files in 
`clang/test/Driver/Inputs/cpunative` that don't contain them, so I think we 
should already have coverage for those cases. Do you see what I mean?

https://github.com/llvm/llvm-project/pull/146323
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to