github-actions[bot] wrote: <!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->
:warning: undef deprecator found issues in your code. :warning: <details> <summary> You can test this locally with the following command: </summary> ``````````bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD llvm/include/llvm/Transforms/Utils/LifetimeMove.h llvm/lib/Transforms/Utils/LifetimeMove.cpp llvm/test/Transforms/Coroutines/coro-split-rise-lifetime-01.ll llvm/test/Transforms/LifetimeMove/erase.ll llvm/test/Transforms/LifetimeMove/escape.ll llvm/test/Transforms/LifetimeMove/indirect_start.ll llvm/test/Transforms/LifetimeMove/loop.ll llvm/test/Transforms/LifetimeMove/multi_critical.ll clang/test/CodeGenCoroutines/pr56919.cpp llvm/lib/Passes/PassBuilder.cpp llvm/lib/Passes/PassBuilderPipelines.cpp llvm/lib/Transforms/Coroutines/CoroFrame.cpp llvm/test/Other/new-pm-defaults.ll llvm/test/Other/new-pm-pgo-preinline.ll llvm/test/Other/new-pm-thinlto-postlink-defaults.ll llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll llvm/test/Other/new-pm-thinlto-prelink-defaults.ll llvm/test/Other/new-pm-thinlto-prelink-pgo-defaults.ll llvm/test/Other/new-pm-thinlto-prelink-samplepgo-defaults.ll llvm/test/Transforms/Coroutines/coro-alloca-07.ll llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-01.ll llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-02.ll llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-03.ll llvm/test/Transforms/Coroutines/coro-split-sink-lifetime-04.ll `````````` </details> The following files introduce new uses of undef: - llvm/test/Transforms/LifetimeMove/erase.ll - llvm/test/Transforms/LifetimeMove/loop.ll [Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead. In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead. For example, this is considered a bad practice: ```llvm define void @fn() { ... br i1 undef, ... } ``` Please use the following instead: ```llvm define void @fn(i1 %cond) { ... br i1 %cond, ... } ``` Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information. https://github.com/llvm/llvm-project/pull/144319 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits