https://github.com/steakhal approved this pull request.

Looks really good. Sweet!

Thank you for this patch. If it works then it works.

There is only one thing though.
We have a couple uses of %clang_cc1 and we could substitute when we are at it.
See an example here https://github.com/llvm/llvm-project/pull/145895

I hope you don't mind this nitpicking.

Thank you for your time for fixing this. I couldn't have done it. I'm sure 
@NagyDonat would say the same.

https://github.com/llvm/llvm-project/pull/146284
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to