llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Adrian Vogelsgesang (vogelsgesang) <details> <summary>Changes</summary> Follow-up fixes to #<!-- -->142651 --- Full diff: https://github.com/llvm/llvm-project/pull/146282.diff 1 Files Affected: - (modified) clang/docs/DebuggingCoroutines.rst (+9-9) ``````````diff diff --git a/clang/docs/DebuggingCoroutines.rst b/clang/docs/DebuggingCoroutines.rst index c47579bc62e51..0ae03380807c2 100644 --- a/clang/docs/DebuggingCoroutines.rst +++ b/clang/docs/DebuggingCoroutines.rst @@ -24,7 +24,7 @@ still improving their support for coroutines. As such, we recommend using the latest available version of your toolchain. This document focuses on clang and lldb. The screenshots show -[lldb-dap](https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.lldb-dap) +`lldb-dap <https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.lldb-dap>`_ in combination with VS Code. The same techniques can also be used in other IDEs. @@ -913,7 +913,7 @@ Note that this script requires LLDB 21.0 or newer. continuation_paths = continuation_paths) - class Coroin-flightCommand(ParsedCommand): + class CoroInflightCommand(ParsedCommand): def get_short_help(self): return "Identify all in-flight coroutines" @@ -993,7 +993,7 @@ Note that this script requires LLDB 21.0 or newer. def __lldb_init_module(debugger, internal_dict): debugger.HandleCommand("command container add -h 'Debugging utilities for C++20 coroutines' coro") debugger.HandleCommand(f"command script add -o -p -c {__name__}.CoroBacktraceCommand coro bt") - debugger.HandleCommand(f"command script add -o -p -c {__name__}.Coroin-flightCommand coro in-flight") + debugger.HandleCommand(f"command script add -o -p -c {__name__}.CoroInflightCommand coro in-flight") print("Coro debugging utilities installed. Use `help coro` to see available commands.") if __name__ == '__main__': @@ -1012,7 +1012,7 @@ For GDB, the following script provides a couple of useful commands: .. code-block:: python - # debugging-helper.py + # debugging-helper.py import gdb from gdb.FrameDecorator import FrameDecorator @@ -1160,11 +1160,11 @@ Further Reading The authors of the Folly libraries wrote a blog post series on how they debug coroutines: -* [Async stack traces in folly: Introduction](https://developers.facebook.com/blog/post/2021/09/16/async-stack-traces-folly-Introduction/) -* [Async stack traces in folly: Synchronous and asynchronous stack traces](https://developers.facebook.com/blog/post/2021/09/23/async-stack-traces-folly-synchronous-asynchronous-stack-traces/) -* [Async stack traces in folly: Forming an async stack from individual frames](https://developers.facebook.com/blog/post/2021/09/30/async-stack-traces-folly-forming-async-stack-individual-frames/) -* [Async Stack Traces for C++ Coroutines in Folly: Walking the async stack](https://developers.facebook.com/blog/post/2021/10/14/async-stack-traces-c-plus-plus-coroutines-folly-walking-async-stack/) -* [Async stack traces in folly: Improving debugging in the developer lifecycle](https://developers.facebook.com/blog/post/2021/10/21/async-stack-traces-folly-improving-debugging-developer-lifecycle/) +* `Async stack traces in folly: Introduction <https://developers.facebook.com/blog/post/2021/09/16/async-stack-traces-folly-Introduction/>`_ +* `Async stack traces in folly: Synchronous and asynchronous stack traces <https://developers.facebook.com/blog/post/2021/09/23/async-stack-traces-folly-synchronous-asynchronous-stack-traces/>`_ +* `Async stack traces in folly: Forming an async stack from individual frames <https://developers.facebook.com/blog/post/2021/09/30/async-stack-traces-folly-forming-async-stack-individual-frames/>`_ +* `Async Stack Traces for C++ Coroutines in Folly: Walking the async stack <https://developers.facebook.com/blog/post/2021/10/14/async-stack-traces-c-plus-plus-coroutines-folly-walking-async-stack/>`_ +* `Async stack traces in folly: Improving debugging in the developer lifecycle <https://developers.facebook.com/blog/post/2021/10/21/async-stack-traces-folly-improving-debugging-developer-lifecycle/>`_ Besides some topics also covered here (stack traces from the debugger), Folly's blog post series also covers more additional topics, such as capturing async strack traces in performance profiles via eBPF filters `````````` </details> https://github.com/llvm/llvm-project/pull/146282 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
