Lancern wrote: I conducted a minor refactor in the latest commit.
Prior to the latest commit, CallOp build functions (namely, `CallOp::build`, `CIRBaseBuilderTy::createCallOp`, and `CIRBaseBuilderTy::createIndirectCallOp`) takes quite a lot parameters, including the extra optional call attributes. I'm worried that this could eventually explode the parameter list of build functions, making them difficult to read and use. The latest commit removes these extra parameters from the build functions, and instead set these attributes on the constructed call op later in a separate step. https://github.com/llvm/llvm-project/pull/145178 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
