================ @@ -18,3 +18,7 @@ void bad_root_signature_3() {} [RootSignature("DescriptorTable(), invalid")] // expected-error {{expected end of stream to denote end of parameters, or, another valid parameter of RootSignature}} void bad_root_signature_4() {} + +// expected-error@+1 {{expected ')' to denote end of parameters, or, another valid parameter of RootConstants}} +[RootSignature("RootConstants(b0, num32BitConstants = 1, invalid)")] ---------------- V-FEXrt wrote:
also I'm aware this comment isn't related to the actual fix of the PR so it's not blocking, just a side point https://github.com/llvm/llvm-project/pull/145827 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits