erichkeane wrote:

> Sure: The first line of the description attempts to define it:
> 
> > Under strict mode, the templated getTrailingObjects can be called only when 
> > there is > 1 trailing types.
> 
> I essentially used this strict mode to find all templated calls to 
> `getTrailingObjects<X>` that could be converted to the simplified 
> non-templated form `getTrailingObjects` in the series of PRs I did over last 
> month. Essentially, what this will do is that any future user of 
> TrailingObjects with a single trailing type will be forced to use the 
> non-templated `getTrailingObjects`.

Oh! I see... hmm...  So this is for cases where we don't know how many items in 
the `TrailingObjects there are... 

I think I might prefer instead of a `strict` template argument, a different 
name for `getTrailingObjects` here, like `getNonCheckedTrailingObjects` (though 
that has other implications... `getNonStrictTrailingObjects<...>` with a 
comment?  

https://github.com/llvm/llvm-project/pull/144930
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to