yaxunl added inline comments.
================ Comment at: test/CodeGenOpenCL/amdgpu-alignment.cl:2 // REQUIRES: amdgpu-registered-target -// RUN: %clang_cc1 -triple amdgcn-unknown-unknown-opencl -S -disable-llvm-passes -emit-llvm -o - %s | FileCheck %s ---------------- tstellar wrote: > You might want to have two run lines for each test, one with no environment > and one with the -opencl environment to make sure that doesn't break in the > future. Otherwise, LGTM. I will add them when committing. Thanks. https://reviews.llvm.org/D33445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
