https://github.com/dwblaikie approved this pull request.

Yeah, let's just go with this as a single patch.

Looking closer, in retrospect/for next time, perhaps this could've been a few 
smaller patches (I guess the strtuct, member, and bit field member are all 
separate except that they depend on the new `MDUnsignedOrMDField` - either that 
could've been included in one of the patches that needed it, and the other two 
patches dependent on that one arbitrarily chosen - or if that could've been 
added/tested independently, then all 3 functional patches independently depend 
on it - (plus the already discussed clang change that could've been done 
separately - but yeah, annoying to have a dependent patch for such a small 
change, so probably fine to keep it in in situations like this then just send a 
tiny PR real quick to go in before the rest once approved)))

https://github.com/llvm/llvm-project/pull/141106
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to