https://github.com/mizvekov requested changes to this pull request.
The fix doesn't look quite right. It's not correct to say that canonicalization changes the declaration name. We don't canonicalize declarations after all. It's just that a canonical template parameter type doesn't refer to a particular template parameter declaration. This change weakens the ODR checker beyond what the fix should require. I can't give a more thorough review at this time since I am still traveling from the WG21 meeting. https://github.com/llvm/llvm-project/pull/144796 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
