https://github.com/5chmidti approved this pull request.
LGTM but I'm +- on the default Let's see if others have a stronger opinion on the default --- Not directly part of this, but: I'd prefer to see a warning for expansions of macros defined inside the code base, but not from macros defined outside of it. (E.g. MY_CLASS vs gtest macros) https://github.com/llvm/llvm-project/pull/143550 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits