================ @@ -139,39 +146,43 @@ initializeRecordStreamer(const Module &M, void ModuleSymbolTable::CollectAsmSymbols( const Module &M, - function_ref<void(StringRef, BasicSymbolRef::Flags)> AsmSymbol) { - initializeRecordStreamer(M, [&](RecordStreamer &Streamer) { - Streamer.flushSymverDirectives(); - - for (auto &KV : Streamer) { - StringRef Key = KV.first(); - RecordStreamer::State Value = KV.second; - // FIXME: For now we just assume that all asm symbols are executable. - uint32_t Res = BasicSymbolRef::SF_Executable; - switch (Value) { - case RecordStreamer::NeverSeen: - llvm_unreachable("NeverSeen should have been replaced earlier"); - case RecordStreamer::DefinedGlobal: - Res |= BasicSymbolRef::SF_Global; - break; - case RecordStreamer::Defined: - break; - case RecordStreamer::Global: - case RecordStreamer::Used: - Res |= BasicSymbolRef::SF_Undefined; - Res |= BasicSymbolRef::SF_Global; - break; - case RecordStreamer::DefinedWeak: - Res |= BasicSymbolRef::SF_Weak; - Res |= BasicSymbolRef::SF_Global; - break; - case RecordStreamer::UndefinedWeak: - Res |= BasicSymbolRef::SF_Weak; - Res |= BasicSymbolRef::SF_Undefined; - } - AsmSymbol(Key, BasicSymbolRef::Flags(Res)); - } - }); + function_ref<void(StringRef, BasicSymbolRef::Flags)> AsmSymbol, + const TargetMachine *TM) { + initializeRecordStreamer( ---------------- teresajohnson wrote:
Why all the reformatting in this function? There are a bunch of lines reformatted in this file that seem unnecessary from a line length perspective from the new TM parameter. https://github.com/llvm/llvm-project/pull/143692 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits