djasper added a comment.

Yes, this definitely does not belong in the NamespaceEndCommentsFixer. It has 
nothing to do with comments.

And I am also very skeptical about several things:

- Why start here? There are many places where semicolons could be cleaned up.
- If we add more of such cleanup functionality, I think we should pull them out 
of the general configuration. This isn't really part of a "style".
- We do have some somewhat related functionality to cleanup in the Cleaner 
class in Format.cpp.

Before going forward with this, I'd like to understand what the long-term plan 
is.


https://reviews.llvm.org/D33314



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to