================ @@ -2636,6 +2636,11 @@ void ModuleImport::processFunctionAttributes(llvm::Function *func, funcOp.setTargetFeaturesAttr( LLVM::TargetFeaturesAttr::get(context, attr.getValueAsString())); + if (llvm::Attribute attr = func->getFnAttribute("reciprocal-estimates"); + attr.isStringAttribute()) ---------------- mcinally wrote:
The other examples follow this same pattern. Do you feel strongly that they should change? ``` if (llvm::Attribute attr = func->getFnAttribute("tune-cpu"); attr.isStringAttribute()) funcOp.setTuneCpuAttr(StringAttr::get(context, attr.getValueAsString())); if (llvm::Attribute attr = func->getFnAttribute("target-features"); attr.isStringAttribute()) funcOp.setTargetFeaturesAttr( LLVM::TargetFeaturesAttr::get(context, attr.getValueAsString())); if (llvm::Attribute attr = func->getFnAttribute("reciprocal-estimates"); attr.isStringAttribute()) funcOp.setReciprocalEstimatesAttr( StringAttr::get(context, attr.getValueAsString())); ``` https://github.com/llvm/llvm-project/pull/143418 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits