shafik wrote:

> If this were a bug, I suspect it would have been reported. Most likely, 
> `dyn_cast_or_null<VarDecl>(Entity.getDecl());` is never null, and could be 
> replaced by `cast`? Did you try that?

It could but that feel like a weak argument, I would like something stronger.

We do `dyn_cast_or_null<VarDecl>(...->getDecl())` in a lot of place, maybe it 
is cargo culting and it is not needed but I can't really tell.

https://github.com/llvm/llvm-project/pull/143067
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to