================ @@ -1831,6 +1831,22 @@ TEST_P(AArch64ExtensionDependenciesBaseCPUTestFixture, } } +TEST(TargetParserTest, testAArch64ReconstructFromParsedFeatures) { + AArch64::ExtensionSet Extensions; + std::vector<std::string> FeatureOptions = { + "-sve2", "-Baz", "+sve", "+FooBar", "+sve2", "+neon", "-sve", + }; + std::vector<std::string> NonExtensions; + Extensions.reconstructFromParsedFeatures(FeatureOptions, NonExtensions); + + std::vector<std::string> NonExtensionsExpected = {"-Baz", "+FooBar"}; + ASSERT_THAT(NonExtensions, testing::ContainerEq(NonExtensionsExpected)); + std::vector<StringRef> Features; + Extensions.toLLVMFeatureList(Features); + std::vector<StringRef> FeaturesExpected = {"+neon", "-sve", "+sve2"}; ---------------- MatzeB wrote:
This particular interface does not seem to resolve dependencies. The point I was trying to make with the test was to that having first `-sve2` followed by a `+sve2` you end up with `+sve2`. While having a `+sve` followed by a `-sve` will end up with `-sve` etc. https://github.com/llvm/llvm-project/pull/142236 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits