aganea wrote: > In this version, Clang emits a full debug IR, but if we're going to do this > by default, it probably makes more sense to emit just a minimal `llvm.dbg.cu` > when debug info isn’t otherwise enabled. I’ve already experimented with that > approach. Yes, I think one of my worry regarding that is the increase build times, since now we would be spawing a `CGDebugInfo` every time now for non-debuginfo builds.
> Also, enabling `/HOTPATCH` by default on x64 is an interesting idea. If we > decide to go that route, then always emitting the compiler info (without > conditioning) makes even more sense. When I added that flag, I noted different preludes being generated with `/HOTPATCH`. Functions have to start with a 2-byte instruction if we enabled this by default which is not always the case. There could be edge cases where the code is shifted in memory and accross the cache lines, and that could cause performance regressions. I think that should be minimal, but it'd be nice to run some standard performance tests if we did that change. https://github.com/llvm/llvm-project/pull/142970 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
