orivej added inline comments.
================ Comment at: include/support/newlib/xlocale.h:20 +#if defined(__NEWLIB__) && (__NEWLIB__ == 2) \ + && defined(__NEWLIB_MINOR__) && (__NEWLIB_MINOR__ >= 5) \ + && (!defined(__POSIX_VISIBLE) || (__POSIX_VISIBLE < 200809)) ---------------- You meant `__NEWLIB_MINOR__ < 5`. Could not this be just the following? ``` #if __NEWLIB__ < 2 || __NEWLIB__ == 2 && __NEWLIB_MINOR__ < 5 #include <support/xlocale/__nop_locale_mgmt.h> #endif ``` https://reviews.llvm.org/D32146 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits