https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/142665
Instead of having a platform specific error diagnostic, use a fixed one
with more direct context for the error.
>From 26277ead2a7f476daaae7c7c972549b6f949d850 Mon Sep 17 00:00:00 2001
From: Paul Kirth <paulki...@google.com>
Date: Tue, 3 Jun 2025 11:29:13 -0700
Subject: [PATCH] [clang-doc] Fix brittle check in test
Instead of having a platform specific error diagnostic, use a fixed one
with more direct context for the error.
---
clang-tools-extra/clang-doc/tool/ClangDocMain.cpp | 3 ++-
clang-tools-extra/test/clang-doc/invalid-options.cpp | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
index 0d2415c619217..15de031aa6091 100644
--- a/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
+++ b/clang-tools-extra/clang-doc/tool/ClangDocMain.cpp
@@ -267,7 +267,8 @@ static llvm::Error handleMappingFailures(llvm::Error Err) {
static llvm::Error createDirectories(llvm::StringRef OutDirectory) {
if (std::error_code Err = llvm::sys::fs::create_directories(OutDirectory))
- return llvm::createFileError(OutDirectory, Err);
+ return llvm::createFileError(OutDirectory, Err,
+ "failed to create directory.");
return llvm::Error::success();
}
diff --git a/clang-tools-extra/test/clang-doc/invalid-options.cpp
b/clang-tools-extra/test/clang-doc/invalid-options.cpp
index 59a0944718e31..15e098ad4c784 100644
--- a/clang-tools-extra/test/clang-doc/invalid-options.cpp
+++ b/clang-tools-extra/test/clang-doc/invalid-options.cpp
@@ -2,7 +2,7 @@
// RUN: rm -rf %t && touch %t
// RUN: not clang-doc %s -output=%t/subdir 2>&1 | FileCheck %s
--check-prefix=OUTPUT-FAIL
// OUTPUT-FAIL: clang-doc error:
-// OUTPUT-FAIL: {{(Not a directory|[Nn]o such file or directory)}}
+// OUTPUT-FAIL-SAME: failed to create directory.
/// Invalid format option.
// RUN: rm -rf %t && mkdir %t && touch %t/file
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
