compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed.
I think that we should sink the `min`/`max` checks into `__undef_macros`. I don't like the idea of littering that check everywhere. ================ Comment at: include/__config:1218 +# if defined(_LIBCPP_COMPILER_MSVC) +# define _LIBCPP_PUSH_MACROS \ + __pragma(push_macro("min")) \ ---------------- clang-format these please? It does a nice job of aligning the `\`. https://reviews.llvm.org/D33080 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits