Sisyph wrote: > Is there a test that needs to be added here?
With just the change to BuiltinsAMDGPU.def, we will get errors in Clang :: CodeGenOpenCL/builtins-amdgcn-gfx950.cl Clang :: CodeGenOpenCL/builtins-amdgcn-load-to-lds.cl Clang :: SemaOpenCL/builtins-amdgcn-load-to-lds-err.cl which the patch to Sema fixes. I don't know of a reasonable way to write a test only target builtin and use of it, to guard against something like __builtin_amdgcn_load_to_lds being removed and then the Sema code being changed. https://github.com/llvm/llvm-project/pull/138141 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
