ilovepi wrote:

> Also, from the CI test run, I see the Linux build failing. This seems 
> unrelated, right? Does it warrant a rerun?
> 
> ```
> /home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/math/smoke/HypotTest.h:31:
>  FAILURE
> Failed to match aNaN against LIBC_NAMESPACE::testing::getMatcher< 
> LIBC_NAMESPACE::testing::TestCond::EQ>(func(sNaN, neg_inf)).
> Expected floating point value: (+Infinity)
> Actual floating point value: (NaN)
> [  FAILED  ] LlvmLibcHypotf16Test.SpecialNumbers
> Ran 1 tests.  PASS: 0  FAIL: 
> 1/home/gha/actions-runner/_work/llvm-project/llvm-project/libc/test/src/math/smoke/HypotTest.h:31:
>  FAILURE
> Failed to match aNaN against LIBC_NAMESPACE::testing::getMatcher< 
> LIBC_NAMESPACE::testing::TestCond::EQ>(func(sNaN, neg_inf)).
> Expected floating point value: (+Infinity)
> Actual floating point value: (NaN)
> [  FAILED  ] LlvmLibcHypotf16Test.SpecialNumbers
> Ran 1 tests.  PASS: 0  FAIL: 1
> ```
> 
> EDIT: I see this `libc/src/math/generic/hypotf16.cpp` was touched recently 
> [here](https://github.com/llvm/llvm-project/commit/062d24a7d6770b1dd7d5a4968bccb28c85495d67).
>  Might get fixed with the rebase.

So, what you're seeing is that main was broken by another patch. Indeed, I 
don't think this has anything to do with you, but if you rebase your patch, or 
update files, it will re-run on a newer main. Likely the failure you see has 
already been reverted, but its hard to say. This happens a lot, since we can't 
run all of our CI as part of pre-merge testing, and there are lots of 
downstream tests running both in our CI (buildbot) and from companies (Google, 
Meta, Intel, SiFive, etc...).

https://github.com/llvm/llvm-project/pull/141699
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to