================
@@ -1432,14 +1432,26 @@ void 
NumericLiteralParser::ParseNumberStartingWithZero(SourceLocation TokLoc) {
     Diags.Report(TokLoc, DiagId);
     ++s;
     DigitsBegin = s;
-    SawOctalPrefix = true;
+    radix = 8;
----------------
AaronBallman wrote:

There's code below which also unconditionally sets `radix` to `8`; we should 
remove that and update the comments. We also seem to skip the octal digits 
twice (I think it's a noop to do it a second time, but it's still a code smell).

https://github.com/llvm/llvm-project/pull/141695
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to