https://github.com/FabianWolff updated https://github.com/llvm/llvm-project/pull/141584
>From eccc89a78d2da840279d584d0b6580269b7fb3fc Mon Sep 17 00:00:00 2001 From: Fabian Wolff <fwo...@google.com> Date: Tue, 27 May 2025 12:13:32 +0000 Subject: [PATCH 1/2] Run `clang-format` --- .../clang-tidy/readability/RedundantSmartptrGetCheck.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp b/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp index baa977750d101..9774d93ff36fd 100644 --- a/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/RedundantSmartptrGetCheck.cpp @@ -66,8 +66,8 @@ void registerMatchersForGetArrowStart(MatchFinder *Finder, // Make sure we are not missing the known standard types. const auto SmartptrAny = anyOf(knownSmartptr(), QuacksLikeASmartptr); - const auto SmartptrWithDeref = - anyOf(cxxRecordDecl(knownSmartptr(), HasRelevantOps), QuacksLikeASmartptr); + const auto SmartptrWithDeref = anyOf( + cxxRecordDecl(knownSmartptr(), HasRelevantOps), QuacksLikeASmartptr); // Catch 'ptr.get()->Foo()' Finder->addMatcher( >From 0b13909591ef4f6fd3fa8c7ea447307632c2265b Mon Sep 17 00:00:00 2001 From: Fabian Wolff <fwo...@google.com> Date: Tue, 27 May 2025 15:09:18 +0000 Subject: [PATCH 2/2] Document change in the release notes --- clang-tools-extra/docs/ReleaseNotes.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index d6f2d2b37624e..e0f81a032c38d 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -249,6 +249,10 @@ Changes in existing checks <clang-tidy/checks/readability/qualified-auto>` check by adding the option `AllowedTypes`, that excludes specified types from adding qualifiers. +- Improved :doc:`readability-redundant-smartptr-get + <clang-tidy/checks/readability/redundant-smartptr-get>` check by fixing + some false positives involving smart pointers to arrays. + Removed checks ^^^^^^^^^^^^^^ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits