kazutakahirata wrote: > I only spotchecked, but it should be good if it still builds. > > Btw, WDYT of IWYU? Maybe we could improve include hygiene for the static > analyzer.
@steakhal Thanks for the review! I personally like the IWYU approach, but the LLVM project uses a different approach -- it's OK to rely on transitive includes. https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible For that reason, I am just removing `#include`s that `misc-include-cleaner` points out while ignoring suggestions to add more `#include`s. https://github.com/llvm/llvm-project/pull/141525 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits