https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/140458
None
>From 7b986a3a76948eea96280bf7e48e4ecfc24e8da4 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <k...@google.com>
Date: Sun, 18 May 2025 07:51:16 -0700
Subject: [PATCH] [clang-tools-extra] Use llvm::max_element (NFC)
---
.../misc/ConfusableTable/BuildConfusableTable.cpp | 8 +++-----
.../clang-tidy/modernize/AvoidBindCheck.cpp | 9 ++++-----
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git
a/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
b/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
index 57190942a1756..18ac7e508165b 100644
--- a/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
+++ b/clang-tools-extra/clang-tidy/misc/ConfusableTable/BuildConfusableTable.cpp
@@ -57,11 +57,9 @@ int main(int argc, char *argv[]) {
llvm::sort(Entries);
unsigned LargestValue =
- std::max_element(Entries.begin(), Entries.end(),
- [](const auto &Entry0, const auto &Entry1) {
- return Entry0.second.size() < Entry1.second.size();
- })
- ->second.size();
+ llvm::max_element(Entries, [](const auto &Entry0, const auto &Entry1) {
+ return Entry0.second.size() < Entry1.second.size();
+ })->second.size();
std::error_code Ec;
llvm::raw_fd_ostream Os(argv[2], Ec);
diff --git a/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
b/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
index 51ee35da623f2..bb06f7ff71d8f 100644
--- a/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
+++ b/clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp
@@ -333,11 +333,10 @@ static void addPlaceholderArgs(const LambdaProperties &LP,
ArrayRef<BindArgument> Args = LP.BindArguments;
- const auto *MaxPlaceholderIt =
- std::max_element(Args.begin(), Args.end(),
- [](const BindArgument &B1, const BindArgument &B2) {
- return B1.PlaceHolderIndex < B2.PlaceHolderIndex;
- });
+ const auto *MaxPlaceholderIt = llvm::max_element(
+ Args, [](const BindArgument &B1, const BindArgument &B2) {
+ return B1.PlaceHolderIndex < B2.PlaceHolderIndex;
+ });
// Placeholders (if present) have index 1 or greater.
if (!PermissiveParameterList && (MaxPlaceholderIt == Args.end() ||
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
