This revision was automatically updated to reflect the committed changes.
Closed by commit rL302317: [clang-tidy] Use cxxStdInitializerListExpr in
modernize-use-emplace (authored by kuhar).
Changed prior to commit:
https://reviews.llvm.org/D32923?vs=98024&id=98034#toc
Repository:
rL LLVM
https://reviews.llvm.org/D32923
Files:
clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
Index: clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
@@ -20,12 +20,6 @@
return Node.hasExplicitTemplateArgs();
}
-namespace impl {
-// FIXME: This matcher should be replaced by a matcher from ASTMatcher.h
-const ast_matchers::internal::VariadicDynCastAllOfMatcher<Stmt,
- CXXStdInitializerListExpr> cxxStdInitializerListExpr;
-} // namespace impl
-
const auto DefaultContainersWithPushBack =
"::std::vector; ::std::list; ::std::deque";
const auto DefaultSmartPointers =
@@ -81,9 +75,7 @@
auto IsPrivateCtor = hasDeclaration(cxxConstructorDecl(isPrivate()));
auto HasInitList = anyOf(has(ignoringImplicit(initListExpr())),
- has(impl::cxxStdInitializerListExpr()));
- // FIXME: Replace internal C++ initializer list matcher with one from
- // ASTMatchers.h
+ has(cxxStdInitializerListExpr()));
// FIXME: Discard 0/NULL (as nullptr), static inline const data members,
// overloaded functions and template names.
Index: clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
===================================================================
--- clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
+++ clang-tools-extra/trunk/clang-tidy/modernize/UseEmplaceCheck.cpp
@@ -20,12 +20,6 @@
return Node.hasExplicitTemplateArgs();
}
-namespace impl {
-// FIXME: This matcher should be replaced by a matcher from ASTMatcher.h
-const ast_matchers::internal::VariadicDynCastAllOfMatcher<Stmt,
- CXXStdInitializerListExpr> cxxStdInitializerListExpr;
-} // namespace impl
-
const auto DefaultContainersWithPushBack =
"::std::vector; ::std::list; ::std::deque";
const auto DefaultSmartPointers =
@@ -81,9 +75,7 @@
auto IsPrivateCtor = hasDeclaration(cxxConstructorDecl(isPrivate()));
auto HasInitList = anyOf(has(ignoringImplicit(initListExpr())),
- has(impl::cxxStdInitializerListExpr()));
- // FIXME: Replace internal C++ initializer list matcher with one from
- // ASTMatchers.h
+ has(cxxStdInitializerListExpr()));
// FIXME: Discard 0/NULL (as nullptr), static inline const data members,
// overloaded functions and template names.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
