[PATCH] D31160: [clang-tidy] Fix misc-move-const-arg for move-only types.

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added inline comments.


================
Comment at: clang-tidy/misc/MoveConstantArgumentCheck.cpp:76
   if (IsConstArg || IsTriviallyCopyable) {
+    if (const CXXRecordDecl *R = Arg->getType()->getAsCXXRecordDecl()) {
+      for (const auto *Ctor : R->ctors()) {
----------------
sbenza wrote:
> Can we get this from R->hasTrivialCopyConstructor or 
> R->hasNonTrivialCopyConstructor instead of iterating all constructors?
Interesting idea, trying `R->hasTrivialCopyConstructor() || 
R->hasNonTrivialCopyConstructor()`.


https://reviews.llvm.org/D31160



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits